Closed Bug 1504072 Opened 7 years ago Closed 6 years ago

Assertion failure: ok (FrameMaintainsOverflow() != ComputeCustomOverflow())

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla67

Tracking Flags:

Tracking

Status

firefox-esr60

---

unaffected

firefox65

---

wontfix

firefox66

---

wontfix

firefox67

---

fixed

People

(Reporter: tsmith, Assigned: violet.bugreport)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase.html 7 years ago Tyson Smith [:tsmith] 99 bytes, text/html		Details
Bug 1504072 - non-display outer SVG also doesn't maintain overflow 6 years ago violet.bugreport 47 bytes, text/x-phabricator-request		Details \| Review

Tyson Smith [:tsmith]

Reporter

Description

•

7 years ago

Attached file testcase.html — Details

Reduced with m-c: BuildID=20181101133336 SourceStamp=182a1b088330a2d72310ae2561004d955571e236 Assertion failure: ok (FrameMaintainsOverflow() != ComputeCustomOverflow()), at src/layout/generic/nsFrame.cpp:9492 #0 nsIFrame::FinishAndStoreOverflow(nsOverflowAreas&, nsSize, nsSize*, nsStyleDisplay const*) src/layout/generic/nsFrame.cpp:9547:11 #1 nsIFrame::FinishAndStoreOverflow(mozilla::ReflowOutput*, nsStyleDisplay const*) src/layout/generic/nsIFrame.h:3226:12 #2 nsSVGOuterSVGFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/svg/nsSVGOuterSVGFrame.cpp:505:3 #3 nsLineLayout::ReflowFrame(nsIFrame*, nsReflowStatus&, mozilla::ReflowOutput*, bool&) src/layout/generic/nsLineLayout.cpp:933:13 #4 nsBlockFrame::ReflowInlineFrame(mozilla::BlockReflowInput&, nsLineLayout&, nsLineList_iterator, nsIFrame*, LineReflowStatus*) src/layout/generic/nsBlockFrame.cpp:4271:15 #5 nsBlockFrame::DoReflowInlineFrames(mozilla::BlockReflowInput&, nsLineLayout&, nsLineList_iterator, nsFlowAreaRect&, int&, nsFloatManager::SavedState*, bool*, LineReflowStatus*, bool) src/layout/generic/nsBlockFrame.cpp:4071:5 #6 nsBlockFrame::ReflowInlineFrames(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) src/layout/generic/nsBlockFrame.cpp:3944:9 #7 nsBlockFrame::ReflowLine(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) src/layout/generic/nsBlockFrame.cpp:2926:5 #8 nsBlockFrame::ReflowDirtyLines(mozilla::BlockReflowInput&) src/layout/generic/nsBlockFrame.cpp:2460:7 #9 nsBlockFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsBlockFrame.cpp:1294:3 #10 nsBlockReflowContext::ReflowBlock(mozilla::LogicalRect const&, bool, nsCollapsingMargin&, int, bool, nsLineBox*, mozilla::ReflowInput&, nsReflowStatus&, mozilla::BlockReflowInput&) src/layout/generic/nsBlockReflowContext.cpp:309:11 #11 nsBlockFrame::ReflowBlockFrame(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) src/layout/generic/nsBlockFrame.cpp:3573:11 #12 nsBlockFrame::ReflowLine(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) src/layout/generic/nsBlockFrame.cpp:2923:5 #13 nsBlockFrame::ReflowDirtyLines(mozilla::BlockReflowInput&) src/layout/generic/nsBlockFrame.cpp:2460:7 #14 nsBlockFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsBlockFrame.cpp:1294:3 #15 nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, unsigned int, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:951:14 #16 nsCanvasFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsCanvasFrame.cpp:803:5 #17 nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, unsigned int, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:951:14 #18 nsHTMLScrollFrame::ReflowScrolledFrame(mozilla::ScrollReflowInput*, bool, bool, mozilla::ReflowOutput*, bool) src/layout/generic/nsGfxScrollFrame.cpp:606:3 #19 nsHTMLScrollFrame::ReflowContents(mozilla::ScrollReflowInput*, mozilla::ReflowOutput const&) src/layout/generic/nsGfxScrollFrame.cpp:730:3 #20 nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsGfxScrollFrame.cpp:1120:3 #21 nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, unsigned int, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:995:14 #22 mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/ViewportFrame.cpp:338:7 #23 mozilla::PresShell::DoReflow(nsIFrame*, bool) src/layout/base/PresShell.cpp:9040:11 #24 mozilla::PresShell::ProcessReflowCommands(bool) src/layout/base/PresShell.cpp:9213:24 #25 mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) src/layout/base/PresShell.cpp:4370:11 #26 nsRefreshDriver::Tick(mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:1932:16 #27 mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) src/layout/base/nsRefreshDriver.cpp:301:7 #28 mozilla::RefreshDriverTimer::Tick(mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:319:5 #29 mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:676:16 #30 mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:573:9 #31 mozilla::layout::VsyncChild::RecvNotify(mozilla::TimeStamp const&) src/layout/ipc/VsyncChild.cpp:76:16 #32 mozilla::layout::PVsyncChild::OnMessageReceived(IPC::Message const&) src/obj-firefox/ipc/ipdl/PVsyncChild.cpp:167:20 #33 mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) src/obj-firefox/ipc/ipdl/PBackgroundChild.cpp:2280:28 #34 mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) src/ipc/glue/MessageChannel.cpp:2255:25 #35 mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) src/ipc/glue/MessageChannel.cpp:2182:17 #36 mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) src/ipc/glue/MessageChannel.cpp:2019:5 #37 mozilla::ipc::MessageChannel::MessageTask::Run() src/ipc/glue/MessageChannel.cpp:2052:15 #38 nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1245:14 #39 NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:530:10 #40 mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:97:21 #41 MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:325:10 #42 MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:298:3 #43 nsBaseAppShell::Run() src/widget/nsBaseAppShell.cpp:158:27 #44 XRE_RunAppShell() src/toolkit/xre/nsEmbedFunctions.cpp:939:22 #45 mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:269:9 #46 MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:325:10 #47 MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:298:3 #48 XRE_InitChildProcess(int, char**, XREChildData const*) src/toolkit/xre/nsEmbedFunctions.cpp:765:34 #49 content_process_main(mozilla::Bootstrap*, int, char**) src/browser/app/../../ipc/contentproc/plugin-container.cpp:50:30 #50 main src/browser/app/nsBrowserApp.cpp:301:18 #51 __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291 #52 _start (firefox+0x329f4)

Flags: in-testsuite?

Emilio Cobos Álvarez (:emilio)

Comment 1

•

7 years ago

Seems like this assertion was added in bug 1483659.

Blocks: 1483659

Flags: needinfo?(mikokm)

violet.bugreport

Assignee

Updated

•

6 years ago

Assignee: nobody → violet.bugreport

violet.bugreport

Assignee

Comment 2

•

6 years ago

Attached file Bug 1504072 - non-display outer SVG also doesn't maintain overflow — Details

There is some inconsistency between nsIFrame::FrameMaintainsOverflow() and
nsSVGContainerFrame::ComputeCustomOverflow(). If an element is a nondisplay
outer SVG, the latter gives false while the former returns true. We make them
consistent since nondisplay element doesn't need to maintain overflow.

violet.bugreport

Assignee

Updated

•

6 years ago

Keywords: checkin-needed

Pulsebot

Comment 3

•

6 years ago

Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f22cf5bfe6f
non-display outer SVG also doesn't maintain overflow r=longsonr

Keywords: checkin-needed

Miko Mynttinen

Comment 4

•

6 years ago

Thank you for fixing this violet!

Flags: needinfo?(mikokm)

Noemi Erli[:noemi_erli]

Comment 5

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/5f22cf5bfe6f

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox67: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla67

BugBot [:suhaib / :marco/ :calixte]

Updated

•

6 years ago

status-firefox66: --- → ?

Ryan VanderMeulen [:RyanVM]

Updated

•

6 years ago

status-firefox65: affected → wontfix

status-firefox66: ? → wontfix

status-firefox-esr60: --- → unaffected

Flags: in-testsuite? → in-testsuite+

violet.bugreport

Assignee

Comment 6

•

6 years ago

•

Edited

Hi Robert,

I found a minor improvement of my previous patch on the check condition for nondisplay outer svg frame.

Previously we use:

HasAllStateBits(NS_STATE_IS_OUTER_SVG | NS_FRAME_IS_NONDISPLAY) &&
         GetContent()->IsSVGElement(nsGkAtoms::svg)

That's ok, but a better way would be using https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsIFrame.h#2804:

IsSVGOuterSVGFrame() && HasAnyStateBits(NS_FRAME_IS_NONDISPLAY)

So that we can directly check the frame and avoid a level of indirection to the element.

How to submit a minor improvement like this?

BTW, then I don't know what's the purpose of having the flag NS_STATE_IS_OUTER_SVG at all, we can just check IsSVGOuterSVGFrame(). Do we need to clean up this flag?

Flags: needinfo?(longsonr)

Robert Longson [:longsonr]

Comment 7

•

6 years ago

(In reply to violet.bugreport from comment #6)

How to submit a minor improvement like this?

Big/small makes no difference, raise a new bug.

BTW, then I don't know what's the purpose of having the flag NS_STATE_IS_OUTER_SVG at all, we can just check IsSVGOuterSVGFrame(). Do we need to clean up this flag?

Good idea, go for it.

Flags: needinfo?(longsonr)

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Assertion failure: ok (FrameMaintainsOverflow() != ComputeCustomOverflow())

Categories

(Core :: Layout, defect)

Tracking

()

People

(Reporter: tsmith, Assigned: violet.bugreport)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Crash Data

Security

(public)

User Story

Attachments

(2 files)

Description

Comment 1

Updated

Comment 2

Updated

Comment 3

Comment 4

Comment 5

Updated

Updated

Comment 6

Comment 7

Attachment

General

Description

File Name

Content Type